node icon indicating copy to clipboard operation
node copied to clipboard

fs: fix incorrect dereferencing of src arg in cpSync

Open npaun opened this issue 1 month ago • 2 comments

Fixes https://github.com/nodejs/node/issues/59168 As for the destination parameter symlink_status and status were accidentally swapped. symlink_status does NOT dereference while status does.

npaun avatar Dec 03 '25 20:12 npaun

CI: https://ci.nodejs.org/job/node-test-pull-request/70381/

nodejs-github-bot avatar Dec 03 '25 20:12 nodejs-github-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.53%. Comparing base (746c3c2) to head (4c47117). :warning: Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60945   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         703      703           
  Lines      208406   208406           
  Branches    40198    40193    -5     
=======================================
+ Hits       184502   184504    +2     
- Misses      15901    15908    +7     
+ Partials     8003     7994    -9     
Files with missing lines Coverage Δ
src/node_file.cc 75.47% <100.00%> (-0.08%) :arrow_down:

... and 28 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 03 '25 21:12 codecov[bot]