crypto: graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable
Ed25519 and X25519 algorithms are no longer experimental. They were merged into the main spec.
https://github.com/nodejs/node/labels/notable-change
Following the merge of Curve25519 into the Web Cryptography API Editor's Draft the
Ed25519andX25519algorithm identifiers are now stable and will no longer emit an ExperimentalWarning upon use.
Review requested:
- [ ] @nodejs/crypto
cc @nodejs/web-standards
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.99%. Comparing base (
3c2da4b) to head (ba640d8). Report is 1363 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #56142 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 656 656
Lines 188999 188995 -4
Branches 35981 35985 +4
=======================================
Hits 166301 166301
+ Misses 15865 15861 -4
Partials 6833 6833
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/internal/crypto/util.js | 93.05% <100.00%> (-0.05%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
CI: https://ci.nodejs.org/job/node-test-pull-request/63895/
The https://github.com/nodejs/node/labels/notable-change label has been added by @richardlau.
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.
https://github.com/nodejs/node/labels/notable-change
Following the merge of Curve25519 into the Web Cryptography API Editor's Draft the
Ed25519andX25519algorithm identifiers are now stable and will no longer emit an ExperimentalWarning upon use.
CI: https://ci.nodejs.org/job/node-test-pull-request/63904/
CI: https://ci.nodejs.org/job/node-test-pull-request/63910/
~The subsystem should be doc: since it's only touching documentation. And since it's doc-only, we should also backport this to 20.x and 18.x, right?~ EDIT: looks like I misread the changes, it does touch lib/. Anyway, should we backport this to maintenance release lines?
Landed in ee8810731dac
panva:webcrypto-stable-curve25519