node icon indicating copy to clipboard operation
node copied to clipboard

cli: allow test coverage, module mocks, and snapshots in `NODE_OPTIONS`

Open JakobJingleheimer opened this issue 1 year ago β€’ 4 comments

After asking the @nodejs/test_runner team, there does not appear to be a particular reason these are not already included.

JakobJingleheimer avatar Dec 02 '24 20:12 JakobJingleheimer

image

No I didn't…

JakobJingleheimer avatar Dec 02 '24 20:12 JakobJingleheimer

@JakobJingleheimer ffr the api request to change github labels is done as a "here's all the labels this issue has" request, not a delta, so there was a race condition between you and the bot. the bot said "it's just these 2!" and you said "it's just this 1!".

ljharb avatar Dec 02 '24 20:12 ljharb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.00%. Comparing base (d5d1e80) to head (df9e99c). Report is 447 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56114   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      189002   189002           
  Branches    36003    36000    -3     
=======================================
+ Hits       166335   166338    +3     
- Misses      15838    15839    +1     
+ Partials     6829     6825    -4     
Files with missing lines Coverage Ξ”
src/node_options.cc 87.55% <100.00%> (ΓΈ)

... and 28 files with indirect coverage changes

codecov[bot] avatar Dec 02 '24 22:12 codecov[bot]

I have no idea why only some flags are allowed in NODE_OPTIONS, and I can't find anyone who knows.

JakobJingleheimer avatar Dec 02 '24 22:12 JakobJingleheimer