node icon indicating copy to clipboard operation
node copied to clipboard

child_process: fix parsing messages with splitted length field

Open MGorkov opened this issue 1 year ago • 1 comments

Fixes: https://github.com/nodejs/node/issues/55834

MGorkov avatar Dec 02 '24 05:12 MGorkov

Hey! Amazing, nice patch, thank you.

Could you please add a test for it?

juanarbol avatar Dec 02 '24 07:12 juanarbol

@juanarbol I've written a test where the child process sends messages to the main, and the third message is split into parts so that the header with the length of the message is split too, which leads to the problem in the current version but my patch solves it

MGorkov avatar Dec 10 '24 09:12 MGorkov

CI: https://ci.nodejs.org/job/node-test-pull-request/64036/

nodejs-github-bot avatar Dec 13 '24 09:12 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.55%. Comparing base (61e4ad5) to head (73a8e0d). Report is 300 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56106      +/-   ##
==========================================
+ Coverage   88.01%   88.55%   +0.53%     
==========================================
  Files         656      657       +1     
  Lines      188982   190248    +1266     
  Branches    35997    36544     +547     
==========================================
+ Hits       166330   168468    +2138     
+ Misses      15825    14960     -865     
+ Partials     6827     6820       -7     
Files with missing lines Coverage Δ
lib/internal/child_process/serialization.js 95.85% <100.00%> (+0.12%) :arrow_up:

... and 136 files with indirect coverage changes

codecov[bot] avatar Dec 13 '24 11:12 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64056/

nodejs-github-bot avatar Dec 14 '24 19:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/64204/

nodejs-github-bot avatar Dec 25 '24 16:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/64238/

nodejs-github-bot avatar Dec 28 '24 07:12 nodejs-github-bot

Landed in 009d53ec3c3a411e9ad28eaae419c95b300cb62a

nodejs-github-bot avatar Jan 18 '25 19:01 nodejs-github-bot