net: support blockList in net.connect
The first PR for https://github.com/nodejs/node/issues/55000
- [x]
make -j4 test(UNIX), orvcbuild test(Windows) passes - [x] tests and/or benchmarks are included
- [x] documentation is changed or added
- [x] commit message follows commit guidelines
Review requested:
- [ ] @nodejs/net
Codecov Report
Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 88.00%. Comparing base (
c7de0ec) to head (51fc034). Report is 9 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/net.js | 80.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #56075 +/- ##
==========================================
+ Coverage 87.99% 88.00% +0.01%
==========================================
Files 656 656
Lines 188967 188988 +21
Branches 35982 35988 +6
==========================================
+ Hits 166275 166319 +44
+ Misses 15859 15838 -21
+ Partials 6833 6831 -2
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/internal/errors.js | 94.33% <100.00%> (+<0.01%) |
:arrow_up: |
| lib/net.js | 93.45% <80.00%> (+0.64%) |
:arrow_up: |
CI: https://ci.nodejs.org/job/node-test-pull-request/63802/
CI: https://ci.nodejs.org/job/node-test-pull-request/63818/
CI: https://ci.nodejs.org/job/node-test-pull-request/63819/
CI: https://ci.nodejs.org/job/node-test-pull-request/63881/
CI: https://ci.nodejs.org/job/node-test-pull-request/63889/
CI: https://ci.nodejs.org/job/node-test-pull-request/63898/
Landed in f26a1da909053173b02deceac9d3beea2d8d2f4d