node icon indicating copy to clipboard operation
node copied to clipboard

lib: add validation for options in compileFunction

Open kimtaejin3 opened this issue 1 year ago • 5 comments

This PR adds a validation step for the options parameter in the compileFunction method within lib/vm.js. The validateObject function is used to ensure that options is an object, aligning with the validation approach used in other functions like measureMemory in lib/vm.js.

kimtaejin3 avatar Nov 27 '24 14:11 kimtaejin3

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.99%. Comparing base (9029aec) to head (8df7b68). Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56023      +/-   ##
==========================================
+ Coverage   87.95%   87.99%   +0.03%     
==========================================
  Files         656      656              
  Lines      188372   188960     +588     
  Branches    35979    35975       -4     
==========================================
+ Hits       165687   166275     +588     
- Misses      15851    15854       +3     
+ Partials     6834     6831       -3     
Files with missing lines Coverage Δ
lib/vm.js 99.28% <100.00%> (+<0.01%) :arrow_up:

... and 59 files with indirect coverage changes

codecov[bot] avatar Nov 27 '24 16:11 codecov[bot]

@legendecas I added the test case, can you please check it?

kimtaejin3 avatar Dec 04 '24 09:12 kimtaejin3

CI: https://ci.nodejs.org/job/node-test-pull-request/63862/

nodejs-github-bot avatar Dec 04 '24 09:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63885/

nodejs-github-bot avatar Dec 05 '24 02:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63900/

nodejs-github-bot avatar Dec 05 '24 15:12 nodejs-github-bot

Landed in 56c8360f878a3ccaf244416d9757ed03ec2e901e

nodejs-github-bot avatar Dec 06 '24 06:12 nodejs-github-bot