node icon indicating copy to clipboard operation
node copied to clipboard

lib: handle Float16Array in node:v8 serdes

Open bartlomieju opened this issue 1 year ago • 6 comments

This commit adds support for Float16Array in node:v8 serde APIs.

While Float16Array is not available as a global yet (pending stabilization in V8), I "reserved" the next available index for serde purposes so other runtimes, like Deno, that already support Float16Array, can support it in node:v8 serde APIs in a future compatible way.

Closes https://github.com/nodejs/node/issues/55574.

bartlomieju avatar Nov 26 '24 01:11 bartlomieju

CC @bnoordhuis @targos

bartlomieju avatar Nov 26 '24 01:11 bartlomieju

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.00%. Comparing base (3511c5c) to head (bce30a4). Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55996      +/-   ##
==========================================
+ Coverage   87.95%   88.00%   +0.04%     
==========================================
  Files         656      656              
  Lines      188304   188935     +631     
  Branches    35972    35972              
==========================================
+ Hits       165624   166271     +647     
+ Misses      15853    15833      -20     
- Partials     6827     6831       +4     
Files with missing lines Coverage Δ
lib/v8.js 98.66% <100.00%> (+0.01%) :arrow_up:

... and 62 files with indirect coverage changes

codecov[bot] avatar Nov 26 '24 04:11 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63767/

nodejs-github-bot avatar Nov 29 '24 06:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63844/

nodejs-github-bot avatar Dec 03 '24 11:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63863/

nodejs-github-bot avatar Dec 04 '24 10:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63866/

nodejs-github-bot avatar Dec 04 '24 11:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63922/

nodejs-github-bot avatar Dec 07 '24 10:12 nodejs-github-bot

Landed in ac7fea6a1239feb9bc8c25281860aeb0e5864bc3

nodejs-github-bot avatar Dec 07 '24 18:12 nodejs-github-bot