test: increase test coverage for `http.OutgoingMessage.appendHeader()`
CI: https://ci.nodejs.org/job/node-test-pull-request/63208/
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.41%. Comparing base (
8ed50bc) to head (11993a4). Report is 45 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #55467 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 653 653
Lines 187485 187478 -7
Branches 36095 36089 -6
=======================================
+ Hits 165764 165765 +1
+ Misses 14966 14955 -11
- Partials 6755 6758 +3
CI: https://ci.nodejs.org/job/node-test-pull-request/63218/
Commit Queue failed
- Loading data for nodejs/node/pull/55467 ✔ Done loading data for nodejs/node/pull/55467 ----------------------------------- PR info ------------------------------------ Title test: increase test coverage for `http.OutgoingMessage.appendHeader()` (#55467) Author Juan José <[email protected]> (@juanarbol) Branch juanarbol:juan/outgoing-coverage -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: increase test coverage for `http.OutgoingMessage.appendHeader()` Committers 1 - Juan José Arboleda <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55467 Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55467 Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 20 Oct 2024 01:41:38 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55467#pullrequestreview-2380693554 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-20T15:44:18Z: https://ci.nodejs.org/job/node-test-pull-request/63218/ - Querying data for job/node-test-pull-request/63218/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11451700447
@aduh95 PTAL
CI: https://ci.nodejs.org/job/node-test-pull-request/63253/
CI: https://ci.nodejs.org/job/node-test-pull-request/63257/
CI: https://ci.nodejs.org/job/node-test-pull-request/63260/
CI: https://ci.nodejs.org/job/node-test-pull-request/63278/
Landed in 1ba8fbe4b82aea8a4e681a5cff6f47521561970d