node icon indicating copy to clipboard operation
node copied to clipboard

tools: update gyp-next to 0.18.3

Open nodejs-github-bot opened this issue 1 year ago • 2 comments

This is an automated update of gyp-next to 0.18.3.

nodejs-github-bot avatar Oct 20 '24 00:10 nodejs-github-bot

Review requested:

  • [ ] @nodejs/gyp

nodejs-github-bot avatar Oct 20 '24 00:10 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.42%. Comparing base (61e52c8) to head (2450f38). Report is 968 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55464   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files         653      653           
  Lines      187513   187513           
  Branches    36096    36104    +8     
=======================================
+ Hits       165791   165805   +14     
+ Misses      14961    14950   -11     
+ Partials     6761     6758    -3     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 20 '24 01:10 codecov[bot]

Does this even need a CI? It's only doc changes on our end.

avivkeller avatar Oct 20 '24 11:10 avivkeller

I think it is not necessary but our tools will complain on it if CI did not run.

legendecas avatar Oct 21 '24 13:10 legendecas

CI: https://ci.nodejs.org/job/node-test-pull-request/63244/

nodejs-github-bot avatar Oct 22 '24 05:10 nodejs-github-bot

Does this even need a CI? It's only doc changes on our end.

If anyone is wondering, [email protected] was not a doc-only update -- it includes the upstream version of https://github.com/nodejs/node/pull/55249 but since that was already applied here it's not showing up in this PR.

richardlau avatar Oct 22 '24 12:10 richardlau

Landed in a3693d2c49f3571a1f80500fd795205575de0a63

nodejs-github-bot avatar Oct 22 '24 12:10 nodejs-github-bot