module: simplify ts under node_modules check
Moves the check from random places in loaders to stripTypeScriptTypes
Review requested:
- [ ] @nodejs/loaders
Doesn't that mean we could not expose the utility to users so they can strip those types manually?
Doesn't that mean we could not expose the utility to users so they can strip those types manually?
Not sure what you mean. You mean we could expose the utility?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.39%. Comparing base (
7ae193d) to head (775e13a). Report is 1434 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #55440 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.02%
==========================================
Files 653 653
Lines 187600 187585 -15
Branches 36117 36117
==========================================
- Hits 165854 165817 -37
- Misses 14974 14989 +15
- Partials 6772 6779 +7
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| lib/internal/modules/cjs/loader.js | 97.15% <ΓΈ> (-0.29%) |
:arrow_down: |
| lib/internal/modules/esm/load.js | 91.98% <ΓΈ> (-0.27%) |
:arrow_down: |
| lib/internal/modules/helpers.js | 99.20% <100.00%> (+0.20%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
CI: https://ci.nodejs.org/job/node-test-pull-request/63175/
CI: https://ci.nodejs.org/job/node-test-pull-request/63181/
Landed in b0ffe9ed355313c2d7c2d655b3af8947b842c683
This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.