node icon indicating copy to clipboard operation
node copied to clipboard

os: improve path check with direct index access

Open mertcanaltin opened this issue 1 year ago • 1 comments

Replaced String.prototype.endsWith with manual string length and index checks for performance improvements.

mertcanaltin avatar Oct 17 '24 19:10 mertcanaltin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.39%. Comparing base (4d6d7d6) to head (c62d231). Report is 984 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55434      +/-   ##
==========================================
- Coverage   88.40%   88.39%   -0.02%     
==========================================
  Files         653      653              
  Lines      187604   187596       -8     
  Branches    36119    36113       -6     
==========================================
- Hits       165849   165822      -27     
- Misses      14983    14992       +9     
- Partials     6772     6782      +10     
Files with missing lines Coverage Δ
lib/os.js 97.34% <100.00%> (-0.01%) :arrow_down:

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 17 '24 22:10 codecov[bot]

test/parallel/test-debugger-break.js

This test passed in my local environment, this is a flakky?

mertcanaltin avatar Oct 21 '24 13:10 mertcanaltin

CI: https://ci.nodejs.org/job/node-test-pull-request/63249/

nodejs-github-bot avatar Oct 22 '24 08:10 nodejs-github-bot

CI failures are unrelated to this patch

juanarbol avatar Oct 31 '24 03:10 juanarbol

CI: https://ci.nodejs.org/job/node-test-pull-request/63355/

nodejs-github-bot avatar Oct 31 '24 03:10 nodejs-github-bot

Landed in 81859cf01f7c0d644a80ec7bdd90f672b3d5444b

nodejs-github-bot avatar Nov 02 '24 15:11 nodejs-github-bot