node icon indicating copy to clipboard operation
node copied to clipboard

Can't run when there is no NULL service on Windows 10/11

Open leehark opened this issue 1 year ago • 6 comments

Version

20.9.0

Platform

No response

Subsystem

electron 29.4.1

What steps will reproduce the bug?

  • Stop the NULL Service on Windows(Or Remove the NULL Service)
  • Run Electron Demo (electron 29.4.1)
  • Can't run with some error

How often does it reproduce? Is there a required condition?

Always when no NULL Service

What is the expected behavior? Why is that the expected behavior?

Normal start Electron Demo

What do you see instead?

Exit with some error

Additional information

Old Electron Version(v22.0) Demo is OK, but latest is bad

leehark avatar Oct 17 '24 06:10 leehark

We found there is a lot of users have not NULL service.

leehark avatar Oct 17 '24 06:10 leehark

https://github.com/nodejs/node/blob/e2242b4e256082e01d8df6a4155ddc80e146c123/src/node.cc#L643C45-L643C47 it stops work in this line

leehark avatar Oct 17 '24 06:10 leehark

Can you reproduce without electron? Please provide some example code.

If you can't reproduce without electron, this may be an issue with Electron, and not Node.js

avivkeller avatar Oct 17 '24 10:10 avivkeller

Additionally, v20.9.0 is ~~EoL~~ not the latest version of that release line. If you can't reproduce on the latest version of the release line, this has probably already been patched.

avivkeller avatar Oct 17 '24 11:10 avivkeller

Additionally, v20.9.0 is EoL. If you can't reproduce on other versions, this is invalid.

since when 20.9.0 is EoL?

marco-ippolito avatar Oct 17 '24 14:10 marco-ippolito

v20.9.0 has been superseded by v20.18.0. If this isn't reproducible in v20.18.0, then it's probably patched.

EoL probably wasn't the best wording, "not the latest version" would've been better

avivkeller avatar Oct 17 '24 14:10 avivkeller

Additionally, v20.9.0 is ~EoL~ not the latest version of that release line. If you can't reproduce on the latest version of the release line, this has probably already been patched.

It can reproduce when it runs with windows application without console, because it want to redirect stdout, stderr to null and it is faileld.

leehark avatar Oct 23 '24 03:10 leehark

runs with windows application without console

Even then the "nul" special file should still be there, it's built into Windows. How come it's not there?

bnoordhuis avatar Oct 23 '24 22:10 bnoordhuis

IMHO this sounds like a system issue. IIUC you are deleting a system file, breakages can be expected in many programs

In any case, "electron demo" isn't a reproducible example, please provide a snippet that can be used for reproduction.

avivkeller avatar Oct 24 '24 00:10 avivkeller

IMHO this sounds like a system issue. IIUC you are deleting a system file, breakages can be expected in many programs

In any case, "electron demo" isn't a reproducible example, please provide a snippet that can be used for reproduction.

did you stop the windows NULL service when reproduce?

leehark avatar Oct 31 '24 02:10 leehark

runs with windows application without console

Even then the "nul" special file should still be there, it's built into Windows. How come it's not there?

I don't know how to produce this environment, but I found that there is about 0.1% of users have no NULL service started, this is the stats, and there is no problem when you are using electron version 22 without NULL service

leehark avatar Oct 31 '24 04:10 leehark

and there is no problem when you are using electron version 22 without NULL service

Then maybe this is a problem with Electron, not Node.js?

avivkeller avatar Oct 31 '24 18:10 avivkeller

and there is no problem when you are using electron version 22 without NULL service

Then maybe this is a problem with Electron, not Node.js?

it crashed in nodejs's code, I don't know who is responsible for it, but nodejs is benefit from electron(it makes more user using nodejs), I think nodejs should improve the stability whether who use it.

leehark avatar Nov 01 '24 02:11 leehark

Following the conclusion from https://github.com/libuv/libuv/issues/4593 I'm going to close this issue too. As it's also previously stated here, this seems like a system issue.

StefanStojanovic avatar Dec 18 '24 10:12 StefanStojanovic