assert: fix deepStrictEqual on errors when cause is present
I tried to follow your suggestion @BridgeAR but doing that after inspection would turn expect and actual into strings which would make the process of removing stack frames, at least for me, complex.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.43%. Comparing base (
5633c62) to head (5ac53d2). Report is 912 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #55406 +/- ##
==========================================
+ Coverage 87.93% 88.43% +0.50%
==========================================
Files 654 654
Lines 187686 187697 +11
Branches 35819 36131 +312
==========================================
+ Hits 165038 165991 +953
+ Misses 15849 14946 -903
+ Partials 6799 6760 -39
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/internal/assert/assertion_error.js | 95.27% <100.00%> (+0.13%) |
:arrow_up: |
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
CI: https://ci.nodejs.org/job/node-test-pull-request/63258/
CI: https://ci.nodejs.org/job/node-test-pull-request/63323/
CI: https://ci.nodejs.org/job/node-test-pull-request/63419/
Landed in 4da8d110f3930e6f97c203e6a3d031cb583f4ca0
This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.
I can do that, folks.
EDIT: By the tags, it looks like @aduh95 backported it.