node
node copied to clipboard
nodejs
test: make `test-node-output-v8-warning` more flexible
This PR makes snapshot testing slightly more flexible so that embedders can run smoke tests against it.
Previous similar PRs:
- https://github.com/nodejs/node/pull/36489
- https://github.com/nodejs/node/pull/54375
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.41%. Comparing base (
2cec716) to head (b1fecba). Report is 1201 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #55401 +/- ##
==========================================
+ Coverage 88.23% 88.41% +0.18%
==========================================
Files 652 652
Lines 183911 186918 +3007
Branches 35858 36074 +216
==========================================
+ Hits 162271 165270 +2999
+ Misses 14916 14889 -27
- Partials 6724 6759 +35
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Commit Queue failed
- Loading data for nodejs/node/pull/55401 ✔ Done loading data for nodejs/node/pull/55401 ----------------------------------- PR info ------------------------------------ Title test: make `test-node-output-v8-warning` more flexible (#55401) Author Shelley Vohr <[email protected]> (@codebytere) Branch codebytere:output-warning-more-generic -> nodejs:main Labels test Commits 1 - test: make test-node-output-v8-warning more flexible Committers 1 - Shelley Vohr <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55401 Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55401 Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 16 Oct 2024 08:27:53 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55401#pullrequestreview-2378922487 ✘ This PR needs to wait 19 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-18T20:33:39Z: https://ci.nodejs.org/job/node-test-pull-request/63191/ - Querying data for job/node-test-pull-request/63191/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11460601806