src: use `Maybe<void>` where bool isn't needed
Review requested:
- [ ] @nodejs/net
Codecov Report
Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
Project coverage is 88.06%. Comparing base (
53ede87) to head (d64b603). Report is 517 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/node_contextify.cc | 33.33% | 4 Missing :warning: |
| src/cares_wrap.cc | 66.66% | 1 Missing :warning: |
| src/string_bytes.h | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #54575 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.01%
==========================================
Files 652 652
Lines 183542 183542
Branches 35862 35858 -4
==========================================
- Hits 161653 161645 -8
- Misses 15144 15149 +5
- Partials 6745 6748 +3
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_contextify.h | 73.33% <ø> (ø) |
|
| src/cares_wrap.cc | 65.44% <66.66%> (ø) |
|
| src/string_bytes.h | 77.77% <66.66%> (ø) |
|
| src/node_contextify.cc | 81.35% <33.33%> (+0.08%) |
:arrow_up: |
CI: https://ci.nodejs.org/job/node-test-pull-request/61641/
CI: https://ci.nodejs.org/job/node-test-pull-request/61687/
CI: https://ci.nodejs.org/job/node-test-pull-request/61731/
CI: https://ci.nodejs.org/job/node-test-pull-request/61782/
CI: https://ci.nodejs.org/job/node-test-pull-request/61813/
CI: https://ci.nodejs.org/job/node-test-pull-request/61827/
Rebased
CI: https://ci.nodejs.org/job/node-test-pull-request/62476/
CI passed. Can I have another review to land?
Landed in d2a4f92920b8257b2f1916440d08057508d54bc0