node icon indicating copy to clipboard operation
node copied to clipboard

test: run V8 Fast API tests in release mode too

Open targos opened this issue 1 year ago • 5 comments

Only keep the call count assertions under common.isDebug.

targos avatar Aug 26 '24 17:08 targos

Review requested:

  • [ ] @nodejs/tsc

nodejs-github-bot avatar Aug 26 '24 17:08 nodejs-github-bot

@anonrig you should like this :)

targos avatar Aug 26 '24 17:08 targos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.34%. Comparing base (4f1c27a) to head (4d5dfea). Report is 317 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54570      +/-   ##
==========================================
+ Coverage   87.33%   87.34%   +0.01%     
==========================================
  Files         649      649              
  Lines      182620   182620              
  Branches    35042    35046       +4     
==========================================
+ Hits       159490   159512      +22     
+ Misses      16394    16376      -18     
+ Partials     6736     6732       -4     

see 34 files with indirect coverage changes

codecov[bot] avatar Aug 26 '24 19:08 codecov[bot]

@anonrig you should like this :)

You know me! 🫡😂

anonrig avatar Aug 26 '24 19:08 anonrig

CI: https://ci.nodejs.org/job/node-test-pull-request/61512/

nodejs-github-bot avatar Aug 26 '24 19:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61688/

nodejs-github-bot avatar Aug 30 '24 05:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61691/

nodejs-github-bot avatar Aug 30 '24 08:08 nodejs-github-bot

Landed in 89667876245bfb8db7aebbd3f6f04abacadf051d

nodejs-github-bot avatar Aug 30 '24 10:08 nodejs-github-bot