nodejs
src: disable fast methods for `buffer.write`
It should resolve the regressions while we work on fixing them.
Refs: https://github.com/nodejs/node/issues/54521
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.33%. Comparing base (
1399d4e) to head (a7a10a7). Report is 323 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54565 +/- ##
==========================================
- Coverage 87.33% 87.33% -0.01%
==========================================
Files 649 649
Lines 182626 182620 -6
Branches 35041 35040 -1
==========================================
- Hits 159503 159489 -14
- Misses 16394 16404 +10
+ Partials 6729 6727 -2
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_buffer.cc | 69.94% <100.00%> (-0.71%) |
:arrow_down: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
If this is accepted, it should be fast-tracked for inclusion in https://github.com/nodejs/node/pull/54560
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bricss please do not approve fast-track requests :] (or you know, start making PRs and join as a collaborator that also works :))
@ronag I don't see a problem in the commit message.
@targos
Commit message must match a given regex pattern: PR-URL: https://github.com/(nodejs|nodejs-private)/(node|node-private)/pull/\d+
This message appears (to collaborators) on all the pull requests of the project. Unfortunately there is no way to customize it but the goal is to prevent merging by accident using the GitHub UI.