nodejs
test: making test-runner-run.mjs ignore colors
Hi! Could you amend your commit message to begin with an active verb? Something like test: ignore colors in `test-runner-run`
Hi! Could you amend your commit message to begin with an active verb? Something like
test: ignore colors in `test-runner-run`
done 😄
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.89%. Comparing base (
26b03c1) to head (120d49b). Report is 27 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54552 +/- ##
==========================================
- Coverage 87.90% 87.89% -0.01%
==========================================
Files 651 651
Lines 183364 183364
Branches 35719 35711 -8
==========================================
- Hits 161182 161174 -8
- Misses 15461 15465 +4
- Partials 6721 6725 +4
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
I guess this commit broke the tests I wrote just a couple of days ago and that now are in the main branch: https://github.com/nodejs/node/commit/52322aa42a43cb820432946e7997d070de078a10
Am I reading this wrong or that commit is actually causing an issue?
Why should I not be allowed to listen on ipv6_link_local which could be locally resolved to a valid IP ?
@puskin94 After looking at the previous implementation, server.listen accepts any string passed into dns.lookup. I started thinking introducing this enforcement might be too restricted. I think it's worth it to discuss more on this. I'll raise it to the original issue thread.
@puskin94 After looking at the previous implementation,
server.listenaccepts any string passed intodns.lookup. I started thinking introducing this enforcement might be too restricted. I think it's worth it to discuss more on this. I'll raise it to the original issue thread.
@jazelly exactly what I am thinking too. I should be allowed to have whatever_i_want in my /etc/hosts file and being able to listen to it, always imho 😄
This should land only if there are other tests that ensures colors work as expected
This should land only if there are other tests that ensures colors work as expected
@MoLow went for a more elegant solution then :) just checking for the colors when in TTY
It may be worth rebasing this to pick up some of the tests marked as flaky.
Failed to start CI
⚠ Something was pushed to the Pull Request branch since the last approving review. ℹ request-ci label was added by a Collaborator after the last push event. - Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 400 Bad Requesthttps://github.com/nodejs/node/actions/runs/10797001710
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}