test: add more fixtures for strip-types
In this MR I'm adding more tests created in this PR, testing generics and Utility Types. This PR makes part of typescript iniciative on Node.
cc: @tniessen @ErickWendel
Can you adjust the commit message to be prefixed with "test", and start with an active verb?
Basically change the beginning to "test: add". Preferably, "test: add more fixtures for strip-types"
Commit message updated @RedYetiDev <3 Thankss!
Hi @kevinuehara I see fixtures being added, but these fixtures are not being tested
HI @marco-ippolito In fact, these fixtures are testing Typescript's own and unique functionalities (Utility Types). If it were not available there would be an error when compiling for Javascript so it can be considered a test and validation of the new ts support functionality
HI @marco-ippolito In fact, these fixtures are testing Typescript's own and unique functionalities (Utility Types). If it were not available there would be an error when compiling for Javascript so it can be considered a test and validation of the new ts support functionality
I'm not sure I understand. Where can I see those .ts files being executed or tested?
There should be a place where these .ts are run and the output is tested or checking they are executed correctly by node --experimental-strip-types.
For example in the original PR the file fixtures/typescript/test-typescript.ts is tested here
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.77%. Comparing base (
1d2603b) to head (ef24e34). Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54107 +/- ##
==========================================
- Coverage 88.06% 87.77% -0.29%
==========================================
Files 651 651
Lines 183386 183386
Branches 35800 35478 -322
==========================================
- Hits 161504 160976 -528
- Misses 15159 15673 +514
- Partials 6723 6737 +14
HI @marco-ippolito In fact, these fixtures are testing Typescript's own and unique functionalities (Utility Types). If it were not available there would be an error when compiling for Javascript so it can be considered a test and validation of the new ts support functionality
I'm not sure I understand. Where can I see those .ts files being executed or tested? There should be a place where these .ts are run and the output is tested or checking they are executed correctly by
node --experimental-strip-types. For example in the original PR the filefixtures/typescript/test-typescript.tsis tested here
Hi @marco-ippolito! I update this PR with the tests
@RedYetiDev @marco-ippolito @ErickWendel can review this PR? 🙏
can you please remove unrelated formatting changes?
also can you amend your first 2 commits with the right author?
can you please remove unrelated formatting changes?
I needed to format and break the line due to lint 🤔
can you please remove unrelated formatting changes?
I needed to format and break the line due to lint 🤔
if it was there it means the lint has passed in the original PR 😄
@marco-ippolito I'll open a new PR with the updates.... I'm having trouble updating the author on the first two commits.