nodejs
fs: fix typings
This does more than just fix typings, can you amend the commit message to reflect that? (or split the PR if the other changes were meant to be separated)
I spent 5+ minutes but couldn't find a good commit message. Any suggestions?
Commit Queue failed
- Loading data for nodejs/node/pull/53626 ✔ Done loading data for nodejs/node/pull/53626 ----------------------------------- PR info ------------------------------------ Title fs: fix typings (#53626) Author Yagiz Niziplihttps://github.com/nodejs/node/actions/runs/9792871085(@anonrig) Branch anonrig:fs-fix-typings -> nodejs:main Labels fs, needs-ci, typings Commits 2 - fs: fix typings - Update lib/fs.js Committers 2 - Yagiz Nizipli - GitHub PR-URL: https://github.com/nodejs/node/pull/53626 Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53626 Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 28 Jun 2024 14:37:25 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53626#pullrequestreview-2149611133 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53626#pullrequestreview-2157909752 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-07-04T01:28:41Z: https://ci.nodejs.org/job/node-test-pull-request/60053/ - Querying data for job/node-test-pull-request/60053/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53626 From https://github.com/nodejs/node * branch refs/pull/53626/merge -> FETCH_HEAD ✔ Fetched commits as ce2faef3a70a..634bd62d0c03 -------------------------------------------------------------------------------- Auto-merging typings/internalBinding/fs.d.ts [main c482d15044] fs: fix typings Author: Yagiz Nizipli Date: Fri Jun 28 10:37:10 2024 -0400 2 files changed, 20 insertions(+), 20 deletions(-) [main 8e868d2d04] Update lib/fs.js Author: Yagiz Nizipli Date: Fri Jun 28 10:52:24 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- fs: fix typings
PR-URL: https://github.com/nodejs/node/pull/53626 Reviewed-By: Antoine du Hamel [email protected] Reviewed-By: James M Snell [email protected]
[detached HEAD 6c463e6ae8] fs: fix typings Author: Yagiz Nizipli [email protected] Date: Fri Jun 28 10:37:10 2024 -0400 2 files changed, 20 insertions(+), 20 deletions(-) Rebasing (3/4) Rebasing (4/4)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- Update lib/fs.js
PR-URL: https://github.com/nodejs/node/pull/53626 Reviewed-By: Antoine du Hamel [email protected] Reviewed-By: James M Snell [email protected]
[detached HEAD b36f1ec04a] Update lib/fs.js Author: Yagiz Nizipli [email protected] Date: Fri Jun 28 10:52:24 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add
commit-queue-squashlabel to land the PR as one commit, orcommit-queue-rebaseto land as separate commits.