node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

vm,src: add property query interceptors

Open legendecas opened this issue 1 year ago • 2 comments

src: remove unused ContextifyContext::WeakCallback

ContextifyContext::WeakCallback is unused.

vm,src: add property query interceptors

Distinguish named property and indexed property when enumerating keys and handle query interceptions.

Co-Authored-By: Michaël Zasso [email protected] Fixes: https://github.com/nodejs/node/issues/52720

Re-landing https://github.com/nodejs/node/pull/53172

/cc @nodejs/vm

legendecas avatar Jun 20 '24 10:06 legendecas

CI: https://ci.nodejs.org/job/node-test-pull-request/59910/

nodejs-github-bot avatar Jun 21 '24 09:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59948/

nodejs-github-bot avatar Jun 24 '24 09:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60105/

nodejs-github-bot avatar Jul 05 '24 20:07 nodejs-github-bot

@joyeecheung would you mind taking a look again? thanks!

legendecas avatar Jul 05 '24 22:07 legendecas

CI: https://ci.nodejs.org/job/node-test-pull-request/60183/

nodejs-github-bot avatar Jul 08 '24 20:07 nodejs-github-bot

Landed in 2b068ffc4a8bc4b2ef0fd46124d48e55af1231b8...c0962dc3bfd94409162fcb77a9da20bce98848c7

nodejs-github-bot avatar Jul 09 '24 09:07 nodejs-github-bot

Label as https://github.com/nodejs/node/labels/dont-land-on-v20.x for breakage in https://github.com/nodejs/node/issues/54436.

legendecas avatar Aug 19 '24 13:08 legendecas

Removed https://github.com/nodejs/node/labels/dont-land-on-v20.x since it is proved to be addressable in userland and can fix more compliance issues.

legendecas avatar Aug 27 '24 09:08 legendecas