node icon indicating copy to clipboard operation
node copied to clipboard

test: do not assume cwd in snapshot tests

Open aduh95 opened this issue 1 year ago • 8 comments

In case the test is run from a different cwd, it should still pass.

aduh95 avatar May 25 '24 10:05 aduh95

Review requested:

  • [ ] @nodejs/test_runner

nodejs-github-bot avatar May 25 '24 10:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59404/

nodejs-github-bot avatar May 25 '24 18:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59408/

nodejs-github-bot avatar May 25 '24 20:05 nodejs-github-bot

Please do not resume CI when it has test failures related to the PR: process.chdir() is not supported in workers

aduh95 avatar May 25 '24 21:05 aduh95

CI: https://ci.nodejs.org/job/node-test-pull-request/59410/

nodejs-github-bot avatar May 25 '24 21:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59438/

nodejs-github-bot avatar May 27 '24 08:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59452/

nodejs-github-bot avatar May 27 '24 14:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59987/

nodejs-github-bot avatar Jun 27 '24 14:06 nodejs-github-bot

Landed in 87598d4b63ef2c827a2bebdfa0f1540c35718519

nodejs-github-bot avatar Jun 30 '24 14:06 nodejs-github-bot