node [v20.x backport] test_runner: make end of work check stricter

This commit updates the logic that checks for the end of the test run. Prior to this change, it was possible for root.run() to be called multiple times because of the way pending subtests were tracked. The extra calls to root.run() were harmless, but could trigger an EventEmitter leak warning due to 'abort' listeners being created.

PR-URL: https://github.com/nodejs/node/pull/52326 Reviewed-By: Benjamin Gruenbaum [email protected] Reviewed-By: Moshe Atlow [email protected] Reviewed-By: Chemi Atlow [email protected]

May 23 '24 18:05 atlowChemi

Review requested:

[ ] @nodejs/test_runner

May 23 '24 18:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59391/

May 24 '24 14:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59407/

May 25 '24 19:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59414/

May 26 '24 05:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59462/

May 27 '24 20:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59731/

Jun 12 '24 07:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59831/

Jun 17 '24 09:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59974/

Jun 26 '24 10:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60348/

Jul 16 '24 10:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/60439/

Jul 19 '24 09:07 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61218/

Aug 19 '24 04:08 nodejs-github-bot

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

Oct 03 '24 15:10 github-actions[bot]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

Nov 03 '24 00:11 github-actions[bot]