node icon indicating copy to clipboard operation
node copied to clipboard

[v20.x] vm: harden module type checks

Open legendecas opened this issue 1 year ago • 1 comments

Check if the value returned from user linker function is a null-ish value.

validateInternalField should be preferred when checking this argument to guard against null-ish this.

Co-authored-by: Mike Ralphson [email protected] PR-URL: https://github.com/nodejs/node/pull/52162 Reviewed-By: Vinícius Lourenço Claro Cardoso [email protected] Reviewed-By: Yagiz Nizipli [email protected]

legendecas avatar May 22 '24 22:05 legendecas

CI: https://ci.nodejs.org/job/node-test-pull-request/59366/

nodejs-github-bot avatar May 23 '24 09:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59732/

nodejs-github-bot avatar Jun 12 '24 07:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59832/

nodejs-github-bot avatar Jun 17 '24 09:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59856/

nodejs-github-bot avatar Jun 18 '24 09:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62621/

nodejs-github-bot avatar Sep 21 '24 09:09 nodejs-github-bot

@marco-ippolito I believe the comment has been addressed.

targos avatar Sep 21 '24 10:09 targos

CI: https://ci.nodejs.org/job/node-test-pull-request/62768/

nodejs-github-bot avatar Sep 25 '24 20:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62781/

nodejs-github-bot avatar Sep 26 '24 06:09 nodejs-github-bot

Landed in f88bf05819d5

targos avatar Sep 26 '24 06:09 targos