node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

src: do not use deprecated V8 API

Open targos opened this issue 1 year ago • 5 comments

Namely:

  • v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, ...);
  • v8::ObjectTemplate::SetNativeDataProperty with AccessControl

Refs: https://github.com/v8/v8/commit/46c241eb99557fe8205acac5c526650c3847d180 Refs: https://github.com/v8/v8/commit/6ec883986bd417e2a42ddb960bd9449deb7e4639

targos avatar May 21 '24 11:05 targos

Review requested:

  • [ ] @nodejs/startup

nodejs-github-bot avatar May 21 '24 11:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59354/

nodejs-github-bot avatar May 22 '24 15:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59358/

nodejs-github-bot avatar May 22 '24 20:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59360/

nodejs-github-bot avatar May 23 '24 07:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59370/

nodejs-github-bot avatar May 23 '24 11:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59382/

nodejs-github-bot avatar May 24 '24 07:05 nodejs-github-bot

@nodejs/cpp-reviewers

targos avatar May 24 '24 07:05 targos

Landed in ff659faeb8858a9fba70027ccfb1a0251fd64e1f...bd151552ef35b0eed415eb1c50d30dafd341cee8

nodejs-github-bot avatar May 27 '24 11:05 nodejs-github-bot