node icon indicating copy to clipboard operation
node copied to clipboard

cli: add `--expose-gc` flag available to `NODE_OPTIONS`

Open juanarbol opened this issue 1 year ago • 6 comments

This commits allows users to send --expose-gc via NODE_OPTIONS environment variable.

Using node --expose-gc is possible but via NODE_OPTIONS won't work.

NODE_OPTIONS='--expose-gc' node
node: --expose-gc is not allowed in NODE_OPTIONS

juanarbol avatar May 21 '24 04:05 juanarbol

CI: https://ci.nodejs.org/job/node-test-pull-request/59330/

nodejs-github-bot avatar May 21 '24 04:05 nodejs-github-bot

Whoops, this needs some tweaks. I'll work on them tomorrow

juanarbol avatar May 21 '24 05:05 juanarbol

CI: https://ci.nodejs.org/job/node-test-pull-request/59335/

nodejs-github-bot avatar May 21 '24 17:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59339/

nodejs-github-bot avatar May 22 '24 05:05 nodejs-github-bot

With https://github.com/nodejs/node/pull/53078#discussion_r1609831586 in mind, is there a legitimate use case for the flag?

targos avatar May 22 '24 12:05 targos

With #53078 (comment) in mind, is there a legitimate use case for the flag?

Debugging heap size.

juanarbol avatar May 22 '24 18:05 juanarbol

Ok, docs are gone now

juanarbol avatar May 25 '24 06:05 juanarbol

CI: https://ci.nodejs.org/job/node-test-pull-request/59459/

nodejs-github-bot avatar May 27 '24 17:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59494/

nodejs-github-bot avatar May 28 '24 16:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59554/

nodejs-github-bot avatar May 30 '24 21:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59638/

nodejs-github-bot avatar Jun 03 '24 18:06 nodejs-github-bot

Landed in b26a260ce595a464b933187c72e9ed06880f75f5

nodejs-github-bot avatar Jun 04 '24 17:06 nodejs-github-bot