node icon indicating copy to clipboard operation
node copied to clipboard

build: use broader detection for 'help'

Open avivkeller opened this issue 1 year ago • 2 comments

This PR updates the vcbuild.bat to use a broader way to detect help/?

avivkeller avatar May 18 '24 13:05 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/59365/

nodejs-github-bot avatar May 23 '24 08:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59374/

nodejs-github-bot avatar May 23 '24 14:05 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/53045
✔  Done loading data for nodejs/node/pull/53045
----------------------------------- PR info ------------------------------------
Title      build: use broader detection for 'help' (#53045)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RedYetiDev:patch-31 -> nodejs:main
Labels     windows, build, author ready, needs-ci
Commits    2
 - build: use broader detection for 'help'
 - Update vcbuild.bat
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53045
Reviewed-By: Stefan Stojanovic 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53045
Reviewed-By: Stefan Stojanovic 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 18 May 2024 13:13:35 GMT
   ✔  Approvals: 3
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/53045#pullrequestreview-2068005716
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53045#pullrequestreview-2073211950
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53045#pullrequestreview-2078304184
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-23T14:44:20Z: https://ci.nodejs.org/job/node-test-pull-request/59374/
- Querying data for job/node-test-pull-request/59374/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   e818eee5af..0d7b5a938c  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 0d7b5a938c doc: move all TLS-PSK documentation to its section
--------------------------------------------------------------------------------
HEAD is now at 0d7b5a938c doc: move all TLS-PSK documentation to its section
   ✔  Reset to origin/main
- Downloading patch for 53045
From https://github.com/nodejs/node
 * branch                  refs/pull/53045/merge -> FETCH_HEAD
✔  Fetched commits as 0d7b5a938c80..b3c2d70d3fb8
--------------------------------------------------------------------------------
Auto-merging vcbuild.bat
[main 295b9b7964] build: use broader detection for 'help'
 Author: Aviv Keller 
 Date: Sat May 18 09:13:15 2024 -0400
 1 file changed, 3 insertions(+), 8 deletions(-)
Auto-merging vcbuild.bat
[main a5f8de17b9] Update vcbuild.bat
 Author: Aviv Keller 
 Date: Mon May 20 07:23:23 2024 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- build: use broader detection for 'help'

PR-URL: https://github.com/nodejs/node/pull/53045 Reviewed-By: Stefan Stojanovic [email protected] Reviewed-By: Antoine du Hamel [email protected] Reviewed-By: James M Snell [email protected]

[detached HEAD dd6a1c7f9f] build: use broader detection for 'help' Author: Aviv Keller [email protected] Date: Sat May 18 09:13:15 2024 -0400 1 file changed, 3 insertions(+), 8 deletions(-) Rebasing (3/4) Rebasing (4/4)

Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- Update vcbuild.bat

PR-URL: https://github.com/nodejs/node/pull/53045 Reviewed-By: Stefan Stojanovic [email protected] Reviewed-By: Antoine du Hamel [email protected] Reviewed-By: James M Snell [email protected]

[detached HEAD a82bd64c3c] Update vcbuild.bat Author: Aviv Keller [email protected] Date: Mon May 20 07:23:23 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9237455242

nodejs-github-bot avatar May 25 '24 18:05 nodejs-github-bot

Landed in d0a7272b57a9e76914b79f7c676096ec1ac1a61b

nodejs-github-bot avatar May 25 '24 19:05 nodejs-github-bot