tools: move webcrypto into no-restricted-properties
Since eslint fixed https://github.com/eslint/eslint/issues/16412 in v8.56.0 here and we are on eslint v8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto.
This is my first pull request to node.js. Please let me know if there is anything to fix.
CI: https://ci.nodejs.org/job/node-test-pull-request/59362/
CI: https://ci.nodejs.org/job/node-test-pull-request/59369/
CI: https://ci.nodejs.org/job/node-test-pull-request/59375/
Can you rebase please? With the move to flat config, there are some conflicts to solve.
Can you rebase please? With the move to flat config, there are some conflicts to solve.
Hi @aduh95, I have rebased my branch. Could you please take a look again and rerun CI for me? Thanks.
I have also removed my TODO as the upgrade of Eslint from v8 to v9 does not cause errors in the test files anymore.
The linter is failing (also it looks like the TODO is still there?)
The linter is failing (also it looks like the TODO is still there?)
Oh sorry. I accidentally dropped one of my commit during interactive rebase. Thank you for spotting it! It should be fixed by now.
CI: https://ci.nodejs.org/job/node-test-pull-request/59431/
CI: https://ci.nodejs.org/job/node-test-pull-request/59464/
Hi @aduh95, I am still seeing 4 failing CI jobs (feels like flaky tests) could you help me take a look, please? Thanks a lot ! 👀
CI: https://ci.nodejs.org/job/node-test-pull-request/59536/
Landed in 74dff83fad3918b20f219c03259088e55930c226