node icon indicating copy to clipboard operation
node copied to clipboard

tools: move webcrypto into no-restricted-properties

Open zeeqko opened this issue 1 year ago • 4 comments

Since eslint fixed https://github.com/eslint/eslint/issues/16412 in v8.56.0 here and we are on eslint v8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto.

This is my first pull request to node.js. Please let me know if there is anything to fix.

zeeqko avatar May 16 '24 11:05 zeeqko

CI: https://ci.nodejs.org/job/node-test-pull-request/59362/

nodejs-github-bot avatar May 23 '24 07:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59369/

nodejs-github-bot avatar May 23 '24 11:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59375/

nodejs-github-bot avatar May 23 '24 15:05 nodejs-github-bot

Can you rebase please? With the move to flat config, there are some conflicts to solve.

aduh95 avatar May 23 '24 20:05 aduh95

Can you rebase please? With the move to flat config, there are some conflicts to solve.

Hi @aduh95, I have rebased my branch. Could you please take a look again and rerun CI for me? Thanks.

I have also removed my TODO as the upgrade of Eslint from v8 to v9 does not cause errors in the test files anymore.

zeeqko avatar May 26 '24 10:05 zeeqko

The linter is failing (also it looks like the TODO is still there?)

aduh95 avatar May 26 '24 10:05 aduh95

The linter is failing (also it looks like the TODO is still there?)

Oh sorry. I accidentally dropped one of my commit during interactive rebase. Thank you for spotting it! It should be fixed by now.

zeeqko avatar May 26 '24 11:05 zeeqko

CI: https://ci.nodejs.org/job/node-test-pull-request/59431/

nodejs-github-bot avatar May 26 '24 23:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59464/

nodejs-github-bot avatar May 27 '24 21:05 nodejs-github-bot

Hi @aduh95, I am still seeing 4 failing CI jobs (feels like flaky tests) could you help me take a look, please? Thanks a lot ! 👀

zeeqko avatar May 30 '24 03:05 zeeqko

CI: https://ci.nodejs.org/job/node-test-pull-request/59536/

nodejs-github-bot avatar May 30 '24 10:05 nodejs-github-bot

Landed in 74dff83fad3918b20f219c03259088e55930c226

nodejs-github-bot avatar May 30 '24 20:05 nodejs-github-bot