path: fix toNamespacedPath on Windows

Open huseyinacacak-janea opened this issue 1 year ago • 2 comments

There was an inconsistency in the implementation of win32.toNamespacedPath(). It appears that the forward slash / wasn't consistently being converted to a backslash \. This PR fixes this issue by returning resolvedPath in the toNamespacedPath().

I've also added a test case to make sure that there will not be any regression.

Fixes: https://github.com/nodejs/node/issues/30224

May 09 '24 06:05 huseyinacacak-janea

CI: https://ci.nodejs.org/job/node-test-pull-request/59052/

May 09 '24 12:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59065/

May 09 '24 20:05 nodejs-github-bot

Is there anything else I can do to help this PR move forward?

May 13 '24 13:05 huseyinacacak-janea

Landed in dcd8b82e15980077941d53560b266c5ed53fb9f0

May 13 '24 13:05 nodejs-github-bot