node icon indicating copy to clipboard operation
node copied to clipboard

doc: update hljs with the latest styles

Open avivkeller opened this issue 1 year ago • 2 comments

This PR updates the hljs.css styling to use the latest styles (from the VSCode theme builtin to Highlight.js)

Dark: image Light: image

avivkeller avatar May 08 '24 23:05 avivkeller

Review requested:

  • [ ] @nodejs/nodejs-website

nodejs-github-bot avatar May 08 '24 23:05 nodejs-github-bot

@ovflowd I know you and that team are updating the docs, just want to make sure this wouldn't break anything

avivkeller avatar May 08 '24 23:05 avivkeller

(removing author-ready, as @aduh95 left comments without approval)

I've made the requested changes in regards to the semicolons. I don't think variables will be effective here, as these stylings are from hljs and if they change in the future, it may be tedious to change each variable

avivkeller avatar May 10 '24 18:05 avivkeller

Just a FYI we're moving away from Highlight.js very soon to Shiki, so I honestly would recommend you to avoid spending calories on any API Docs-related changes... in general, as all these styles will be discarded.

ovflowd avatar May 10 '24 22:05 ovflowd

Landed in 29884d1d5c5fde35dec29f842834c766d5aee059

nodejs-github-bot avatar May 13 '24 10:05 nodejs-github-bot