node icon indicating copy to clipboard operation
node copied to clipboard

test: allow recursive testing

Open avivkeller opened this issue 1 year ago • 7 comments

Blocks #52875

This PR gives the test runner support for recursive searching for test files. This is being backported, as in #52875 (and similar future PRs), testing will (hopefully) be moved to subdirectories.

avivkeller avatar May 08 '24 15:05 avivkeller

@nodejs/testing @nodejs/backporters

avivkeller avatar May 08 '24 15:05 avivkeller

By the way, this PR should be backported to 18 and 20, I'm not sure if the labels I applied are correct.

avivkeller avatar May 08 '24 17:05 avivkeller

Thanks @richardlau, I'm new to backporting. For the future, what would be the appropriate labels?

avivkeller avatar May 08 '24 18:05 avivkeller

Possibly lts-watch-*, although strictly speaking it shouldn't be necessary for a release line in active LTS (e.g. 20.x).

Refer to https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

richardlau avatar May 08 '24 18:05 richardlau

Possibly lts-watch-*, although strictly speaking it shouldn't be necessary for a release line in active LTS (e.g. 20.x).

Refer to main/doc/contributing/backporting-to-release-lines.md

Okay, thanks. Should I add lts-watch for 18 and 20? This change should be the exact same for the other lines, as I don't think the files that this is editing have changed.

avivkeller avatar May 08 '24 18:05 avivkeller

@targos, is there anything in particular I need to do for the backport?

avivkeller avatar May 09 '24 20:05 avivkeller

As @richardlau suggested: add lts-watch-* labels.

targos avatar May 10 '24 06:05 targos

Unfortunately, the eslint changes have resulting in this PR needing the modification of files that no longer exist. I've reopened this PR at #53309

avivkeller avatar Jun 03 '24 17:06 avivkeller