test: move 'http' tests into subfolder
This PR moves all of the parallel/test-http-* files into parallel/http/test-*. If this change goes well, I look to implement it throughout the entire parallel folder (one subsystem at a time)
IMO, the DX will be much easier with this change, as searching through tests will become simpler, as users can simply visit the test/parallel/<subsystem> directory.
From a maintenance point of view, CODEOWNERS and label rules should be simpler, as a subdirectory now exists for these subsystems.
The http subsystem is largest subsystem (in number of test files), so I decided to handle it first.
This PR is a step towards parity with #52859
(CC Original participants: @targos @MoLow)
Does it work well with the parallel.status file?
I updated the file, so it should work, but I haven't done hard testing
Can you still run only "http" tests with ./tools/test.py http ?
Can you still run only "http" tests with
./tools/test.py http?
It seems not, but I'll build a fix for that now
Okay, now it is possible :-)
@targos i'll test the parallel.status file now
parallel.status works fine :-). I forgot to push it, and now that it's pushed, it works.
@nodejs/http @nodejs/testing
Requesting a CI, as this PR has two approves, and a CI is probably going to be needed before merge.
CI: https://ci.nodejs.org/job/node-test-pull-request/59038/
I'm somewhat concerned that this would make backporting commits harder. I think we would need backport PRs done immediately for all lines (18, 20) before landing this.
Okay, I'll open backport PRs soon.
This will add the initial support: https://github.com/nodejs/node/pull/52901
FWIW, many tests do not fit cleanly into any particular subsystem, and I don't see how we'd consistently apply test/parallel/<subsystem> in those cases.
There are almost 500 open PRs. Aside from backporting, we would need to ensure that PRs such as this one are not going to cause mass conflicts in dozens of other PRs.
I am not in favor, but also not strongly opposed, assuming all relevant git and GitHub operations keep referring to the actual changes and not to the mass renames.
It doesn't need to be consistently applied, tests not put in a folder will run the same way. The behavior that i would hope to be implemented in the blocking PR would allow for tests to appear in sub folders.
As for the mass conflicts, I'm aware of the wave of them that will come, but I'm prepared to handle it, because I think this will really do some good
Closing until blocking PR is merged, as the merge conflicts will only increase.