node icon indicating copy to clipboard operation
node copied to clipboard

test: unskip v8-updates/test-linux-perf-logger

Open lukealbao opened this issue 1 year ago • 7 comments

This patch fixes #51308. It includes commit to re-enable the test by reverting #52821.

Explanation

This test suite is a dependency-free port of test/v8-updates/test-linux-perf.js. In both cases, js code is evaluated in a child process with v8 options set to emit a symbol table for perf(1). Verification is done by regex lookup. In the output, a function foo will be distinguished as compiled or interpreted based on a unary prefix character. Test cases use v8 option arguments to the child process to ensure compilation when applicable.

In 2023 (I don't know how to identify the release version), v8 added a new additional flag to guard optimization (link). This patch includes that in the child process options.

lukealbao avatar May 07 '24 01:05 lukealbao

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5964/

nodejs-github-bot avatar May 07 '24 05:05 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5964/

nodejs-github-bot avatar May 07 '24 05:05 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5964/

nodejs-github-bot avatar May 07 '24 05:05 nodejs-github-bot

08:06:57 ok 2 v8-updates/test-linux-perf-logger
08:06:57   ---
08:06:57   duration_ms: 709.58200
08:06:57   ...
08:06:57 
08:06:57 All tests passed.

targos avatar May 07 '24 06:05 targos

CI: https://ci.nodejs.org/job/node-test-pull-request/59014/

nodejs-github-bot avatar May 07 '24 15:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59025/

nodejs-github-bot avatar May 08 '24 05:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59026/

nodejs-github-bot avatar May 08 '24 06:05 nodejs-github-bot

Landed in c0c598d753d5...4ef5bc1fdcbb.

richardlau avatar May 29 '24 13:05 richardlau