node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

build: improve makefile to be os agnostic

Open anonrig opened this issue 1 year ago • 5 comments

For certain vsbuild.bat actions, it executes makefile and on PowerShell it was throwing error for me because uname doesn't exist. This pull-request doesn't solve all Windows related issues in makefile but makes the terminal output a lot cleaner.

cc @nodejs/platform-windows @nodejs/build

anonrig avatar May 06 '24 22:05 anonrig

CI: https://ci.nodejs.org/job/node-test-pull-request/59012/

nodejs-github-bot avatar May 07 '24 13:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59023/

nodejs-github-bot avatar May 08 '24 00:05 nodejs-github-bot

cc @nodejs/platform-windows @lemire can you take a look?

anonrig avatar May 08 '24 00:05 anonrig

Unrelated to this PR, but do we build Node for Windows ARM64 in CI?

lemire avatar May 08 '24 00:05 lemire

@lemire yes, here: https://ci.nodejs.org/job/node-compile-windows/55884/nodes=win-vs2022-arm64/

targos avatar May 08 '24 04:05 targos