nodejs
doc: added Buffer.from(string) to functions that use buffer pool
Buffer.from(string) is one of the functions that may use the pre-allocated buffer. It's mentioned in the description of Buffer.from(array), but not in Buffer.from(string), or in the two other places where functions that behave this way are listed, so this commit adds those references.
There appear to be a number of additional commits here that are unrelated to the doc change. Can I ask you to remove the extra commits?
There appear to be a number of additional commits here that are unrelated to the doc change. Can I ask you to remove the extra commits?
Sorry about that, everything should be cleaned up now.
@jasnell Does this change feel substantive? I wanted to make this PR when I had some time, because I'd used buffer.from(string) and was confused as to why the underlying buffer had other data in it. When I didn't see any explanation in the buffer.from(string) section of the docs, I actually went to the source code and found where the buffer pool was used when creating strings long before I noticed that this behavior was documented at the bottom of buffer.from(array) 😂.
It would've saved me some time had it been in the buffer.from(string) section of the docs, so I thought it might help others as well.
If anyone has capacity to review this PR, I'd greatly appreciate it! If it doesn't seem worth including, I can certainly close it 🙂
Oh, sorry for asking one more thing but can you please change the commit message to use add instead of added, is just for the commit message conventions.
Oh, sorry for asking one more thing but can you please change the commit message to use
addinstead ofadded, is just for the commit message conventions.
No problem! I'll keep that in mind for future PRs 🙂
@Whitecx congratulations on your first PR, thanks for contributing!
Thank you!! And thank you for supporting with your review 😊