nodejs
[v20.x backport] streams: fixes for webstreams
Manual backport of #51168 to v20.x. Depends on #52772, so keeping this in draft until that one lands.
This one was a bit tricky, since there are changes to transferables on v22.x that are not on v20.x (such as #50107) which also affect web streams. However, I think I made it work. 🤞
can you fix the conflicts? I'll try to backport it in the next v20 release
Hi @MattiasBuelens I was backporting your commits, I encountered some issue, can you please cherry-pick the landed commits from the original PR (example https://github.com/nodejs/node/pull/51168#issuecomment-1869556329), instead of the commits from your fork, so that they contain metadata like PR-URL and reviewers, and please squash the fixup commits
@marco-ippolito I've squashed the commits on this PR and rebased them onto v20.x-staging.
The original PR didn't have the most prominent change in the first commit, so we landed it in https://github.com/nodejs/node/commit/20c63134fcd86468a940ab447bb092bdc2238389 with the unimaginative title "stream: fix code style". 😅 I changed it to "stream: fixes for webstreams" for this PR, if that's okay.
@marco-ippolito I've squashed the commits on this PR and rebased them onto
v20.x-staging.The original PR didn't have the most prominent change in the first commit, so we landed it in https://github.com/nodejs/node/commit/20c63134fcd86468a940ab447bb092bdc2238389 with the unimaginative title "stream: fix code style". 😅 I changed it to "stream: fixes for webstreams" for this PR, if that's okay.
You can just cherry-pick the landed commits from the original PR (at the end of the pr in the comment from the bot landed in ...) and squash only the fixup commits