nodejs
tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo
Changing existing error code values is always semver-major.
Good to know! Thanks!
Ack! I totally forgot to update the commit message.
I'll do it in a few hours...
Commit Queue failed
- Loading data for nodejs/node/pull/52627 ✔ Done loading data for nodejs/node/pull/52627 ----------------------------------- PR info ------------------------------------ Title tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (#52627) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:fix-tls-error-typo -> nodejs:main Labels crypto, c++, semver-major, author ready, needs-ci Commits 1 - tls: fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo Committers 1 - RedYetiDev <[email protected]> PR-URL: https://github.com/nodejs/node/pull/52627 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52627 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 Apr 2024 19:52:53 GMT ✔ Approvals: 2 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/52627#pullrequestreview-2084824754 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/52627#pullrequestreview-2053861852 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-30T08:25:52Z: https://ci.nodejs.org/job/node-test-pull-request/58815/ - Querying data for job/node-test-pull-request/58815/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10525204300
semver-major requires at least 2 TSC approvals
The more you know the more you know...
This PR needs one more TSC approval to land. I've added the review wanted label.
PR is currently blocked from landing by unreliable CI.
Is that still the case? Except for the skipped MacOS runner, the CI on this LGTM
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.06%. Comparing base (
1d2603b) to head (ce040bd). Report is 121 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #52627 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 651 651
Lines 183386 183386
Branches 35800 35795 -5
=======================================
+ Hits 161504 161506 +2
+ Misses 15159 15157 -2
Partials 6723 6723
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/crypto/crypto_tls.cc | 78.73% <100.00%> (ø) |
|
| src/node_errors.h | 84.21% <ø> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}