lib: create global console properties at snapshot build time

Open joyeecheung opened this issue 1 year ago • 3 comments

It is safe to create the console properties for the global console at snapshot build time. Streams must still be created lazily however because they need special synchronization for the handles.

Feb 07 '24 23:02 joyeecheung

Looks like you need to update the code owners file

Feb 08 '24 08:02 targos

Removed the leftover benchmark rename (probably got it from https://github.com/nodejs/node/pull/51669)

Feb 09 '24 16:02 joyeecheung

Looks like there was a git error and I added the stream initialization back into the snapshot. Removed again.

Feb 13 '24 14:02 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/57161/

Feb 17 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57187/

Feb 20 '24 02:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57191/

Feb 20 '24 05:02 nodejs-github-bot

Landed in 7851af051ab72401ca5b2dcf24f8a0f72d24a9f2

Feb 20 '24 18:02 nodejs-github-bot