build: fix warning in cares under GN build
This change can be removed after the upstream fix lands in Node: https://github.com/c-ares/c-ares/pull/709
Review requested:
- [ ] @nodejs/net
- [ ] @nodejs/security-wg
Can this be merged? It is currently breaking GN build.
+1 It is breaking V8 Node CI. Duplicate: https://github.com/nodejs/node/pull/51756
This should be merged quickly after the security release.
Fast-track has been requested by @juanarbol. Please 👍 to approve.
CI: https://ci.nodejs.org/job/node-test-pull-request/57077/
CI: https://ci.nodejs.org/job/node-test-pull-request/57230/
CI: https://ci.nodejs.org/job/node-test-pull-request/57232/
CI: https://ci.nodejs.org/job/node-test-pull-request/57233/
CI: https://ci.nodejs.org/job/node-test-pull-request/57238/
CI: https://ci.nodejs.org/job/node-test-pull-request/57241/
CI: https://ci.nodejs.org/job/node-test-pull-request/57245/
CI: https://ci.nodejs.org/job/node-test-pull-request/57250/
CI: https://ci.nodejs.org/job/node-test-pull-request/57318/
CI: https://ci.nodejs.org/job/node-test-pull-request/57327/
Commit Queue failed
- Loading data for nodejs/node/pull/51687 ✔ Done loading data for nodejs/node/pull/51687 ----------------------------------- PR info ------------------------------------ Title build: fix warning in cares under GN build (#51687) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:cares-warning -> nodejs:main Labels cares, needs-ci, dependencies, commit-queue-squash Commits 1 - build: fix warning in cares under GN build Committers 1 - Cheng Zhaohttps://github.com/nodejs/node/actions/runs/8015803850PR-URL: https://github.com/nodejs/node/pull/51687 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Juan José Arboleda ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51687 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Juan José Arboleda -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix warning in cares under GN build ℹ This PR was created on Wed, 07 Feb 2024 05:21:35 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867015435 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867295688 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/51687#pullrequestreview-1880447000 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-23T05:51:27Z: https://ci.nodejs.org/job/node-test-pull-request/57327/ - Querying data for job/node-test-pull-request/57327/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Landed in f22802ceb89a