node icon indicating copy to clipboard operation
node copied to clipboard

build: fix warning in cares under GN build

Open zcbenz opened this issue 1 year ago • 6 comments

This change can be removed after the upstream fix lands in Node: https://github.com/c-ares/c-ares/pull/709

zcbenz avatar Feb 07 '24 05:02 zcbenz

Review requested:

  • [ ] @nodejs/net
  • [ ] @nodejs/security-wg

nodejs-github-bot avatar Feb 07 '24 05:02 nodejs-github-bot

Can this be merged? It is currently breaking GN build.

zcbenz avatar Feb 13 '24 02:02 zcbenz

+1 It is breaking V8 Node CI. Duplicate: https://github.com/nodejs/node/pull/51756

victorgomes avatar Feb 14 '24 14:02 victorgomes

This should be merged quickly after the security release.

targos avatar Feb 14 '24 14:02 targos

Fast-track has been requested by @juanarbol. Please 👍 to approve.

github-actions[bot] avatar Feb 14 '24 19:02 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/57077/

nodejs-github-bot avatar Feb 14 '24 19:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57230/

nodejs-github-bot avatar Feb 21 '24 03:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57232/

nodejs-github-bot avatar Feb 21 '24 06:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57233/

nodejs-github-bot avatar Feb 21 '24 06:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57238/

nodejs-github-bot avatar Feb 21 '24 07:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57241/

nodejs-github-bot avatar Feb 21 '24 08:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57245/

nodejs-github-bot avatar Feb 21 '24 10:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57250/

nodejs-github-bot avatar Feb 21 '24 11:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57318/

nodejs-github-bot avatar Feb 23 '24 01:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57327/

nodejs-github-bot avatar Feb 23 '24 05:02 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/51687
✔  Done loading data for nodejs/node/pull/51687
----------------------------------- PR info ------------------------------------
Title      build: fix warning in cares under GN build (#51687)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     zcbenz:cares-warning -> nodejs:main
Labels     cares, needs-ci, dependencies, commit-queue-squash
Commits    1
 - build: fix warning in cares under GN build
Committers 1
 - Cheng Zhao 
PR-URL: https://github.com/nodejs/node/pull/51687
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Juan José Arboleda 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51687
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Juan José Arboleda 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - build: fix warning in cares under GN build
   ℹ  This PR was created on Wed, 07 Feb 2024 05:21:35 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867015435
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867295688
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/51687#pullrequestreview-1880447000
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-02-23T05:51:27Z: https://ci.nodejs.org/job/node-test-pull-request/57327/
- Querying data for job/node-test-pull-request/57327/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/8015803850

nodejs-github-bot avatar Feb 23 '24 07:02 nodejs-github-bot

Landed in f22802ceb89a

zcbenz avatar Feb 23 '24 07:02 zcbenz