nodejs
doc: document the GN build
Commit Queue failed
- Loading data for nodejs/node/pull/51676 ✔ Done loading data for nodejs/node/pull/51676 ----------------------------------- PR info ------------------------------------ Title doc: document the GN build (#51676) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:patch-16 -> nodejs:main Labels doc, author ready Commits 2 - doc: document the GN build - solve review comments Committers 1 - Cheng Zhaohttps://github.com/nodejs/node/actions/runs/7839027752PR-URL: https://github.com/nodejs/node/pull/51676 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51676 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 06 Feb 2024 07:38:09 GMT ✔ Approvals: 4 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51676#pullrequestreview-1865129648 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51676#pullrequestreview-1868163517 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/51676#pullrequestreview-1870860955 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51676#pullrequestreview-1871583729 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51676 From https://github.com/nodejs/node * branch refs/pull/51676/merge -> FETCH_HEAD ✔ Fetched commits as 8a41d9b636be..9cc929bfe67c -------------------------------------------------------------------------------- [main 4c1504f6d6] doc: document the GN build Author: Cheng Zhao Date: Tue Feb 6 16:36:53 2024 +0900 1 file changed, 112 insertions(+) create mode 100644 doc/contributing/gn-build.md [main 160d3b3d4b] solve review comments Author: Cheng Zhao Date: Wed Feb 7 14:54:44 2024 +0900 1 file changed, 30 insertions(+), 17 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc: document the GN build
PR-URL: https://github.com/nodejs/node/pull/51676 Reviewed-By: Marco Ippolito [email protected] Reviewed-By: Joyee Cheung [email protected] Reviewed-By: Debadree Chatterjee [email protected] Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD b332db3649] doc: document the GN build Author: Cheng Zhao [email protected] Date: Tue Feb 6 16:36:53 2024 +0900 1 file changed, 112 insertions(+) create mode 100644 doc/contributing/gn-build.md Rebasing (3/4) Rebasing (4/4)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- solve review comments
PR-URL: https://github.com/nodejs/node/pull/51676 Reviewed-By: Marco Ippolito [email protected] Reviewed-By: Joyee Cheung [email protected] Reviewed-By: Debadree Chatterjee [email protected] Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD 38285d1023] solve review comments Author: Cheng Zhao [email protected] Date: Wed Feb 7 14:54:44 2024 +0900 1 file changed, 30 insertions(+), 17 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ Add
commit-queue-squashlabel to land the PR as one commit, orcommit-queue-rebaseto land as separate commits.