test_runner: use validateStringArray for `timers.enable()`
apis which is argument of timers.enable() is string array. So use validatStringArray instead of validateArray. And
options is optional, so update JSDoc.
In document, some default value of timers are missed such as setImmediate and clearImmediate. Next, milliseconds which is argument of `timers.tick() is optional and default is 1.
Review requested:
- [ ] @nodejs/test_runner
cc @ErickWendel PTAL when you are available.
CI: https://ci.nodejs.org/job/node-test-pull-request/53817/
This needs a rebase.
CI: https://ci.nodejs.org/job/node-test-pull-request/56953/
CI: https://ci.nodejs.org/job/node-test-pull-request/56966/
@deokjinkim please do not add https://github.com/nodejs/node/labels/request-ci label on PRs that already have a running CI, it adds up unnecessary load to the CI infrastructure, and won't make the PR land sooner. At the very least, please cancel the running CI first.
CI: https://ci.nodejs.org/job/node-test-pull-request/57000/
CI: https://ci.nodejs.org/job/node-test-pull-request/57020/
CI: https://ci.nodejs.org/job/node-test-pull-request/57032/
This needs a rebase.
@lpinca I rebased this PR. Could you review again?
Can you add a test that's failing on
mainand passing on this branch please?
Thank you for review. I added a test you mentioned :)