node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

build: fix `configure --link-module`

Open richardlau opened this issue 2 years ago • 5 comments

Add the list of linked modules to the arguments for js2c.py. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows.

Fixes: https://github.com/nodejs/node/issues/42302 Refs: https://github.com/nodejs/node/pull/39069

richardlau avatar Jun 22 '23 15:06 richardlau

Review requested:

  • [ ] @nodejs/gyp

nodejs-github-bot avatar Jun 22 '23 15:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52348/

nodejs-github-bot avatar Jun 22 '23 15:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52354/

nodejs-github-bot avatar Jun 22 '23 16:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52360/

nodejs-github-bot avatar Jun 22 '23 18:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52362/

nodejs-github-bot avatar Jun 22 '23 19:06 nodejs-github-bot

Landed in ae9f919880e17eb98b207963bcac2395ea4ffac2

nodejs-github-bot avatar Jun 24 '23 15:06 nodejs-github-bot

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

ruyadorno avatar Sep 10 '23 03:09 ruyadorno