node icon indicating copy to clipboard operation
node copied to clipboard

test: use unusual chars in the path to ensure our tests are robust

Open aduh95 opened this issue 2 years ago • 5 comments

Hopefully our tests should work without assuming the repo is cloned in path that contains unusual chars.

aduh95 avatar Jun 10 '23 15:06 aduh95

Review requested:

  • [ ] @nodejs/actions

nodejs-github-bot avatar Jun 10 '23 15:06 nodejs-github-bot

TIL GNU Make does not support files containing whitespaces nor %, that's… unexpected.

aduh95 avatar Jun 10 '23 15:06 aduh95

Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo.

targos avatar Jun 25 '23 06:06 targos

Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo.

I'm pretty sure it's just about the branch name for this PR, not related to the content of this PR.

console.log("\u2020\u00A3\u00A7\u2122" === '†£§™'); // true

aduh95 avatar Jun 25 '23 08:06 aduh95

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.54%. Comparing base (48c75bc) to head (55edf5d). Report is 1237 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #48409   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         657      657           
  Lines      190395   190395           
  Branches    36552    36550    -2     
=======================================
+ Hits       168580   168590   +10     
+ Misses      14993    14986    -7     
+ Partials     6822     6819    -3     

see 35 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 22 '24 11:08 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64156/

nodejs-github-bot avatar Dec 22 '24 22:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/64175/

nodejs-github-bot avatar Dec 23 '24 17:12 nodejs-github-bot

Landed in d2af8819970ee69bbee5b9ca7888f9ea3c1017d7

nodejs-github-bot avatar Dec 30 '24 00:12 nodejs-github-bot