node icon indicating copy to clipboard operation
node copied to clipboard

test: define NAPI_VERSION before including node_api.h

Open legendecas opened this issue 2 years ago • 2 comments

Include node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file.

Fixes https://github.com/nodejs/node/issues/48310

legendecas avatar Jun 07 '23 12:06 legendecas

CI: https://ci.nodejs.org/job/node-test-pull-request/52219/

nodejs-github-bot avatar Jun 12 '23 06:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52399/

nodejs-github-bot avatar Jun 23 '23 15:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52416/

nodejs-github-bot avatar Jun 24 '23 07:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52422/

nodejs-github-bot avatar Jun 24 '23 10:06 nodejs-github-bot

Landed in e7a1fab25f7be9fc470aae4927b910d2b75e37dc

nodejs-github-bot avatar Jun 24 '23 17:06 nodejs-github-bot