node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

[v16.x backport] WebCryptoAPI fixes

Open panva opened this issue 2 years ago • 12 comments

We can safely bring v16.x WebCryptoAPI spec conformance to the level of our other LTS/current releases with the backport of these PRs:

  • #46042
  • #46043
  • #45320
  • #44917
  • #45569
  • #46067
  • #46563
  • #47877

NB: WebCryptoAPI is still https://github.com/nodejs/node/labels/experimental in v16.x

panva avatar Mar 31 '23 11:03 panva

Review requested:

  • [ ] @nodejs/crypto

nodejs-github-bot avatar Mar 31 '23 11:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/50744/

nodejs-github-bot avatar Mar 31 '23 12:03 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/50750/

nodejs-github-bot avatar Mar 31 '23 14:03 nodejs-github-bot

The asan detected leak is not introduced by the fixes. It's the updated wpts that run into a branch with a memory leak that was fixed in #43202.

We can either

  • not update the WPTs to not run into the leak in CI
  • get #43202 backported too

panva avatar Apr 01 '23 07:04 panva

CI: https://ci.nodejs.org/job/node-test-pull-request/50787/

nodejs-github-bot avatar Apr 01 '23 13:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/50796/

nodejs-github-bot avatar Apr 01 '23 18:04 nodejs-github-bot

cc @nodejs/backporters

panva avatar Apr 02 '23 12:04 panva

@panva I'm preparing v16.x for 4/4 - looks like this still needs reviewers before it can be landed.

danielleadams avatar Apr 02 '23 21:04 danielleadams

@danielleadams there was 16.x minor release 4 days ago... There's another one planned for tuesday 4/4?

panva avatar Apr 02 '23 21:04 panva

cc @nodejs/crypto

panva avatar Apr 03 '23 11:04 panva

CI: https://ci.nodejs.org/job/node-test-pull-request/51820/

nodejs-github-bot avatar May 15 '23 19:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/51823/

nodejs-github-bot avatar May 15 '23 20:05 nodejs-github-bot

This is no longer likely to make an impact on v16.x LTS with its EOL in ~6 week

panva avatar Jul 26 '23 09:07 panva