node icon indicating copy to clipboard operation
node copied to clipboard

doc,lib: remove deprecated domain module

Open bnoordhuis opened this issue 3 years ago • 3 comments

Fixes: https://github.com/nodejs/node/issues/45824


Draft PR to check citgm. The REPL was leaning quite heavily on domains so REPL tests are expected to fail. I didn't want to spend time on that for a trial balloon.

I deleted lib/domain.js for now but in the final version it should probably throw an exception (not emit a warning.)

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3060/

bnoordhuis avatar Dec 13 '22 08:12 bnoordhuis

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/startup

nodejs-github-bot avatar Dec 13 '22 08:12 nodejs-github-bot

Draft PR to check citgm.

I might be telling you something you already know, but just in case: You can open a PR like this against your own fork and then put bnoordhuis rather than nodejs as the GITHUB_ORG in the Jenkins build parameter. The upside is you avoid alarming people or attracting PR reviews. The downside is that the results won't be documented in a PR in the main repo, so I'm fine with doing it this way instead.

EDIT: Added some additional labels to hopefully further dissuade people from thinking this is ready for review. Feel free to remove them at any time.

Trott avatar Dec 14 '22 14:12 Trott

(I've removed the blocked label, as this technically isn't blocked by any specific issues)

avivkeller avatar Sep 24 '24 13:09 avivkeller

Draft PR to check citgm. The REPL was leaning quite heavily on domains so REPL tests are expected to fail. I didn't want to spend time on that for a trial balloon.

@bnoordhuis see https://github.com/nodejs/node/pull/55204, that should handle the REPL. Once that lands, are you still interested in persueing this PR?

avivkeller avatar Oct 30 '24 13:10 avivkeller