node icon indicating copy to clipboard operation
node copied to clipboard

stream: export consumers and web in parent builtin

Open Mesteery opened this issue 4 years ago • 7 comments

Mesteery avatar Sep 23 '21 19:09 Mesteery

cc @nodejs/repl

Mesteery avatar Sep 25 '21 14:09 Mesteery

Fwiw, that's not what I was suggesting. Just expose consumers as a property of stream.

@jasnell Is this what you are suggesting? By the way I added a test to make sure that all current and future modules export their "submodules" if there are any.

Mesteery avatar Nov 25 '21 19:11 Mesteery

It seems to break a few tests.

targos avatar Nov 26 '21 15:11 targos

It seems to break a few tests.

This is because https://github.com/nodejs/node/blob/43e127801425d0ddb1b23b86c3788603d00d6da3/lib/internal/bootstrap/loaders.js#L294 calls the getter and thus triggers the ExperimentalWarning of stream/web.

I don't really know what to do in this case.

Mesteery avatar Nov 26 '21 17:11 Mesteery

Updated to export only stable submodules in their parent builtin.

Mesteery avatar Feb 14 '22 11:02 Mesteery

This needs a rebase.

aduh95 avatar May 11 '24 17:05 aduh95

There are some linter error that needs fixing

aduh95 avatar May 21 '24 10:05 aduh95