node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

lib: aggregate errors to avoid error swallowing

Open aduh95 opened this issue 4 years ago • 3 comments

aduh95 avatar Sep 03 '21 13:09 aduh95

Missing tests?

mscdex avatar Sep 03 '21 18:09 mscdex

Missing tests?

Most of this stuff is hard to test reliably (I didn't find a way to generate an error on closing a file descriptor), but I did add a test for http.ClientRequest change which is more easily testable.

aduh95 avatar Sep 04 '21 00:09 aduh95

Ping @nodejs/tsc for reviews.

aduh95 avatar Sep 15 '21 16:09 aduh95