node icon indicating copy to clipboard operation
node copied to clipboard
verified publisher icon nodejs

test: add http agent to executionAsyncResource

Open psj-tar-gz opened this issue 5 years ago • 6 comments

I added a testcase about executionAsyncResource with Http Agent.

Refs: https://github.com/nodejs/node/blob/master/test/async-hooks/test-async-exec-resource-http.js Signed-off-by: psj-tar-gz [email protected]

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

psj-tar-gz avatar Aug 29 '20 08:08 psj-tar-gz

Isn't it needed to execute at least two http requests to the same server to see the diff between use of the dedicated agent versus the global agent?

Flarna avatar Sep 04 '20 12:09 Flarna

CI: https://ci.nodejs.org/job/node-test-pull-request/33068/

nodejs-github-bot avatar Sep 05 '20 12:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/34193/

nodejs-github-bot avatar Nov 08 '20 11:11 nodejs-github-bot

@psj-tar-gz Linter complains about a few findings. A rebase to current master is maybe also a good idea.

Flarna avatar Nov 09 '20 16:11 Flarna

CI: https://ci.nodejs.org/job/node-test-pull-request/35650/

nodejs-github-bot avatar Jan 21 '21 09:01 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58970/

nodejs-github-bot avatar May 05 '24 22:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59077/

nodejs-github-bot avatar May 10 '24 17:05 nodejs-github-bot

Landed in https://github.com/nodejs/node/pull/34966/commits/491855c82b01359df0006d1936e8eb71cafd19c9

aduh95 avatar May 11 '24 08:05 aduh95