node icon indicating copy to clipboard operation
node copied to clipboard

process: improve rejections tracking performance

Open mmarchini opened this issue 5 years ago • 4 comments

Fixes: https://github.com/nodejs/node/issues/34851

Before landing
  • [ ] Explain why this works on commit message
  • [ ] Add comments to the code to explain what's going on
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

mmarchini avatar Aug 21 '20 07:08 mmarchini

CI: https://ci.nodejs.org/job/node-test-pull-request/32877/

nodejs-github-bot avatar Aug 21 '20 08:08 nodejs-github-bot

Test failures look legit, but I can't reproduce locally

mmarchini avatar Aug 21 '20 23:08 mmarchini

Just following up on this since it looks like the CI process got fixed (or at least it is no longer reporting). Can we re-run the CI to see if your patch passes?

matt4530 avatar Sep 07 '20 21:09 matt4530

@H4ad

We can close this PR now ;)

Uzlopak avatar May 06 '24 20:05 Uzlopak